Fix: Modify the time_eval func in utils.py for killing timeout sub-process #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you just correct the two little errors, sot github will be happy? thanks! |
|
I've deleted the whitespaces and pushed the new version. Does that work? |
|
let see, this approval is a pain, I relaxed it... |
|
I set up a python 3.9 virtual env for test and the process got stuck and there was no informative error or exception returned. But everything went well on python 3.8. |
|
Sorry, i forgot this, I fixed the last bugs for making the CI pass, it is good to merge on your side, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: pipe broken on Ubuntu 22.04
cause: too many zombie subprocesses are not killed when time out
fix: time_eval in utils.py
environment: python==3.8
P.S. It's my first time to make the open request. I'm not sure if I have an appropriate operation and discussion. If there is any trouble or mistake, please feel free to inform me.